Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for voice reconnect on session reconnect #1350

Merged
merged 4 commits into from Jun 5, 2023

Conversation

loghinalexandru
Copy link
Contributor

@loghinalexandru loghinalexandru commented Mar 13, 2023

This PR adds a flag in order to prevent voice reconnect on session reconnect. The default value is set to true so it should not affect the initial behaviour.

Resolves #1349

@loghinalexandru loghinalexandru marked this pull request as draft March 13, 2023 17:29
@loghinalexandru loghinalexandru marked this pull request as ready for review March 13, 2023 17:39
@loghinalexandru loghinalexandru changed the title Add flag for voice reconnect on session reconnect Add toggle for voice reconnect on session reconnect Mar 13, 2023
structs.go Outdated Show resolved Hide resolved
discord.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
@FedorLap2006
Copy link
Collaborator

Sorry for a long wait!

@loghinalexandru
Copy link
Contributor Author

No problem 😃. I've added the suggested changes.

Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually after a bit of thinking, I think we're going to move forward with this doc comment.
As we don't reconnect only on errors.

structs.go Outdated Show resolved Hide resolved
@FedorLap2006 FedorLap2006 merged commit a90485d into bwmarrin:master Jun 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session reconnect forces voice reconnect
2 participants