Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelEdit: omit empty Position #1385

Merged
merged 1 commit into from Jun 5, 2023
Merged

ChannelEdit: omit empty Position #1385

merged 1 commit into from Jun 5, 2023

Conversation

FedorLap2006
Copy link
Collaborator

Convert ChannelEdit.Position to a pointer and add omitempty JSON option.

@FedorLap2006
fix(ChannelEdit)!: omit empty Position
0cc76cc 
Make Position field a pointer and add omitempty JSON option to avoid
setting it to 0 when it is not specified.
@FedorLap2006 FedorLap2006 added fix Pull requests and issues related to bug fixes and structural inconsistencies breaking changes Contains breaking changes. Should be reflected in the changelog structs API structs and constants related changes labels Jun 5, 2023
@FedorLap2006 FedorLap2006 added this to the v0.28.0 milestone Jun 5, 2023
@FedorLap2006 FedorLap2006 self-assigned this Jun 5, 2023
@FedorLap2006 FedorLap2006 merged commit af63880 into master Jun 5, 2023
16 checks passed
@FedorLap2006 FedorLap2006 deleted the channeledit-position-omitempty branch June 5, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FedorLap2006 FedorLap2006

Labels
breaking changes Contains breaking changes. Should be reflected in the changelog fix Pull requests and issues related to bug fixes and structural inconsistencies structs API structs and constants related changes
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FedorLap2006