New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new username system #1387
feat: support new username system #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't think we had done this before, I think it's a good idea to put all table tests under a subtest (with the name being something along the lines of "String()"
or "Conversion to a string"
).
Also, please note the checks. |
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
yap, do we need a standardization related to the unit test? I think all features will need this since the package become bigger |
change `tt` to `tc`. the purpose is to make the variable better communicate. Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
any update for this @FedorLap2006 ? |
Same, this is kinda needed because of global display names |
I've updated this code, please review it again. Thanks, @FedorLap2006 |
Additionally, not quite sure about the separation of However, it's quite late, so I'll decide on that tomorrow. |
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
okay, so keep the |
Basically, but with a couple more changes. See my comment above. |
…ildan77/discordgo into feat/support-username-only
I've updated this code, please review it again. Thanks, @FedorLap2006 |
I might make the change myself tho, since I understand that everyone wants to have this change 😅 |
311040f
to
d38ce10
Compare
😅Hahah thanks for the changes. Glad to know for the new update |
Use regular int instead of uint64 for return value of User.DefaultAvatarIndex and idx parameter of EndpointDefaultUserAvatar.
Want to give a bit of explanation behind my last commit: After reading into the documentation and asking around, I've found that user should have only Additionally, with a bit of consideration, I've decided to move the comment, since it's probably going to be better if we explain the |
b038674
to
e9835e7
Compare
And this one - I decided to switch the article to more general version, but decided to undo it, as the |
Thanks for your contribution! |
I see, so just simply compare for the "0" value of the discriminator. |
Ur welcome, glad to know if there are many cases that can be improved |
Problem
closes #1386
Unit Test Check