Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Examples #201

Merged
merged 6 commits into from
May 21, 2016
Merged

Avatar Examples #201

merged 6 commits into from
May 21, 2016

Conversation

VagantemNumen
Copy link
Contributor

Examples demonstrating changing of avatar with local files and remote urls.

@bwmarrin
Copy link
Owner

I think for the purpose of these examples we should remove the Message Create call back entirely so that the examples just focus on the require calls to change the avatar. So also won't even need to open a websocket either. Keep them very short and to the point so it's easier to understand for new users what's actually required.

Also, thanks a lot for the PR :) I really do appreciate the help. If you don't mind could you try updating them to remove the websocket/handler stuff?

@bwmarrin bwmarrin added this to the v0.13.0 milestone May 17, 2016
@bwmarrin bwmarrin added the feature Feature implementation label May 17, 2016
@VagantemNumen
Copy link
Contributor Author

Sure.

of the example being simple and to the point.
Added a disclaimer regarding visual change to the main README.md.
@VagantemNumen
Copy link
Contributor Author

Done.

@bwmarrin
Copy link
Owner

bwmarrin commented May 19, 2016

Great. One more thing, I was thinking it might be best to not include any images. Keep the repo lighter and avoid any potential complains for using these trademarked images. I think the example still shows the steps clear enough that users can provide their own image.

@VagantemNumen
Copy link
Contributor Author

VagantemNumen commented May 19, 2016

Done.

@bwmarrin
Copy link
Owner

Awesome :) Thanks a lot, it's a great addition.

@bwmarrin bwmarrin merged commit ee608e6 into bwmarrin:develop May 21, 2016
@VagantemNumen
Copy link
Contributor Author

Glad to be of help. Well if you think of any other example that maybe useful I am more than happy to code them.

alex-j-butler pushed a commit to alex-j-butler/discordgo that referenced this pull request Nov 5, 2016
Add examples for setting account avatar
@VagantemNumen VagantemNumen deleted the examples branch November 7, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants