add support for pinning #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks a lot of the PR :) Looks great. One question, when you call these endpoints does Discord return anything? Often it will return the object that was modified. If that's the case here I'd like to return that as well from these functions back to the caller. |
|
Calling them returns an empty 204 response and judging by how similar returns were handled, I handled them the same. |
|
k, just checking :) Looks great - again thanks a lot, I really appreciate the help. 👍 |
alex-j-butler
pushed a commit
to alex-j-butler/discordgo
that referenced
this pull request
Nov 5, 2016
Add support for message pinning, closes bwmarrin#219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219