Fix all found race conditions, and dont send on nil channel #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I'm going to run this on Septapus for a few days and make sure there's no deadlocks, then merge. |
|
nice nice |
|
you find any problems with it @iopred ? |
|
Ack, so sorry Jonas, Septapus is now running with this patch. This time tomorrow should be enough :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some locking was incorrect, a lot was missing, i fixed all race conditions i could find using the
-racedetector on different bots.I have tested shorter voice connections by having a bot connect to voice, play a 2 second long audio file, then disconnect, every 5 seconds for some hours.
Tested longer connections by having a music bot play a track on loop for a couple hours.
This will lower performance a bit, but it's better than to rely on undefined behaviour.
This pr is probably gonna be annoying to go through with all the new locking, sorry about that.