Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ChannelMessageSendEmbedWithMessage #335

Merged
merged 2 commits into from
Mar 13, 2017
Merged

Added ChannelMessageSendEmbedWithMessage #335

merged 2 commits into from
Mar 13, 2017

Conversation

Seklfreak
Copy link
Contributor

No description provided.

restapi.go Outdated
@@ -1335,6 +1335,30 @@ func (s *Session) ChannelMessageSendEmbed(channelID string, embed *MessageEmbed)
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this method to:

return s.ChannelSendEmbedWithMessage(channelID, "", embed)

seems like that should work.

@Seklfreak
Copy link
Contributor Author

Thanks. I applied your suggested change and tested it. It works.

@iopred iopred merged commit b7f00b3 into bwmarrin:develop Mar 13, 2017
@jD91mZM2
Copy link
Contributor

jD91mZM2 commented Apr 5, 2017

So... shouldn't we do this with edit as well?

@bwmarrin bwmarrin added this to the v0.16.0 milestone Apr 18, 2017
ErikMcClure pushed a commit to ErikMcClure/discordgo that referenced this pull request Aug 4, 2020
* Added ChannelMessageSendEmbedWithMessage

* Updates ChannelMessageSendEmbed to use ChannelMessageSendEmbedWithMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants