Methods to obtain a user's avatar URL #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iopred
reviewed
May 29, 2017
user.go
Outdated
| if strings.HasPrefix(avatarID, "a_") { | ||
| extension = ".gif" | ||
| } | ||
| return EndpointCDNAvatars + userID + "/" + avatarID + extension + "?size=" + size |
There was a problem hiding this comment.
Hmm, I would prefer:
func (u *User) AvatarURL(size string) string {
var url string
if strings.HasPrefix(avatarID, "a_) {
url = EndpointUserAvatarAnimated(userID, avatarID)
} else {
url = EndpointUserAvatar(userID, avatarID)
}
return url + "?size=" + size
}
We already support EndpointUserAvatar, adding an animated one seems reasonable.
There was a problem hiding this comment.
I noticed that the EndpointUserAvatar function requests a png image. Does the file format change to a png when you request it as one?
There was a problem hiding this comment.
Updated the code with the things you suggested, apparently it does return a PNG file.
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
* Methods to obtain a user's avatar URL * Created EndpointUserAvatarAnimated and updated AvatarURL * Fixed the size parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes obtaining the avatar URL of a user easier.