Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#429-Fix #432

Merged
merged 1 commit into from
Aug 19, 2017
Merged

#429-Fix #432

merged 1 commit into from
Aug 19, 2017

Conversation

Hinara
Copy link
Contributor

@Hinara Hinara commented Aug 19, 2017

Fix #429

@iopred iopred merged commit d6b616c into bwmarrin:develop Aug 19, 2017
@qaisjp
Copy link
Contributor

qaisjp commented Aug 24, 2017

Uh, not sure if this is a proper fix. shouldn't it unmarshal an error if 204 NO CONTENT is not sent?

@Hinara
Copy link
Contributor Author

Hinara commented Aug 24, 2017

@qaisjp
I do exactly the same as other functions that have 204 in response.
If you feel that this is not the good solution please open an issue
Edit: Currently the error return the Unmarshal response code if it can

return s.request(method, urlStr, "application/json", body, bucketID, 0)

err = newRestError(req, resp, response)

err := json.Unmarshal(body, &msg)

@Hinara Hinara deleted the #429-Fix branch August 24, 2017 23:07
@bwmarrin bwmarrin added this to the v0.17.0 milestone Sep 3, 2017
qaisjp added a commit to qaisjp/go-discord-irc that referenced this pull request Aug 18, 2018
ErikMcClure pushed a commit to ErikMcClure/discordgo that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants