Implement Raw sending of status (Rich Presence and Online Status) #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Doesn't do it on save because Gogland removed it and their new thing I can't make sense of.
iopred
reviewed
Oct 20, 2017
wsapi.go
Outdated
| // UpdateOnlineStatus is used to update the user's online status | ||
| // If idle>0 and status=="online" then set status to idle | ||
| // If otherwise, set status to the given value and no game | ||
| func (s *Session) UpdateOnlineStatus(status string, afk bool, idle int) (err error) { |
There was a problem hiding this comment.
I don't think we need to bother with this now.
iopred
reviewed
Oct 20, 2017
wsapi.go
Outdated
| // If game!="" then set game | ||
| // If game!="" and url!="" then set the status type to streaming with the URL set. | ||
| // If otherwise, set status to the given value and no game | ||
| func (s *Session) UpdateOnlineStreamingStatus(status string, afk bool, idle int, game string, url string) (err error) { |
There was a problem hiding this comment.
I don't think we need this either, or at least make this private.
This reverts commit 235cd15.
iopred
reviewed
Oct 20, 2017
structs.go
Outdated
| Type GameType `json:"type"` | ||
| URL string `json:"url,omitempty"` | ||
| Name string `json:"name"` | ||
| Type int `json:"type"` |
There was a problem hiding this comment.
Change Type back to GameType, changing to int is an api change.
wsapi.go
Outdated
| @@ -276,7 +276,7 @@ func (s *Session) UpdateStreamingStatus(idle int, game string, url string) (err | |||
| return ErrWSNotFound | |||
There was a problem hiding this comment.
Move this block into UpdateStatusComplex, it should be thread safe too! :)
There was a problem hiding this comment.
Sorry, I think you missed this, we should move the RLock/wsConn check to UpdateStatusComplex.
There was a problem hiding this comment.
Yeah sorry I missed that.
wsapi.go
Outdated
| @@ -291,11 +291,16 @@ func (s *Session) UpdateStreamingStatus(idle int, game string, url string) (err | |||
| } | |||
| usd.Game = &Game{ | |||
| Name: game, | |||
| Type: gameType, | |||
| Type: int(gameType), | |||
|
Oops, my apologies, looks like we need the cast when creating the Game, but we should keep the API as using GameType. |
|
Thanks so much for this <3 |
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
…marrin#462) * Added ability to change the online status * Add structs for rick presence implementation * Refractor and publicise UpdateStatusData * Add UpdateStatusComplex for raw status data sending * Case gameType to int, stopped it compiling * Might want to gofmt. Doesn't do it on save because Gogland removed it and their new thing I can't make sense of. * Revert "Added ability to change the online status" This reverts commit 235cd15. * Change gametypeto match * Move RLock to UpdateStatusComplex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ikkerens had his cloned and Rich Presence was implemented on top of this.