feature: add ChannelVoiceJoinManual #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves bwmarrin#577. ChannelVoiceJoinManual is a wrapper over sending an OP4 to Discord, for initiating a voice server connection. The library's builtin voice connection management locks/maps are skipped, and the library will not attempt to manage this voice connection. Users are expected to hook the VoiceServerUpdate event and forward the data to an outside voice manager, such as Lavalink.
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
…ection feature: add ChannelVoiceJoinManual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #577.
ChannelVoiceJoinManual is a wrapper over sending an OP4 to Discord, for
initiating a voice server connection. The library's builtin voice
connection management locks/maps are skipped, and the library will not
attempt to manage this voice connection.
Users are expected to hook the VoiceServerUpdate event and forward the
data to an outside voice manager, such as Lavalink.
This PR has been tested and is working against https://github.com/foxbot/gavalink/blob/master/example/main.go