Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fan] Change Rotation Speed from percentage to levels #534

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

vadimpronin
Copy link
Contributor

This PR changes units for Rotation Speed of a Fan from % to speed levels.
Sonoff fans have only 3 speed settings presented as Roman numerals on the remote (I, II, III).
Original implementation presented these levels as 33%, 66% and 99% in HAP.
Changing them to 1, 2 and 3 seems more intuitive and inline with original sonoff design


fan_settings
fan_badge

@bwp91
Copy link
Owner

bwp91 commented Dec 27, 2023

Oh wow I did not even know this scale/functionality was available in HAP. Might look into changing my other plugins too!

Out of interest, if you are using the existing version of the plugin with % scales, then change git branch to your changes, does the scale automatically update in the home app? or does it require removing the accessory for it to be re-added with the new scales?

@bwp91 bwp91 merged commit 362fc91 into bwp91:latest Dec 27, 2023
5 checks passed
@bwp91
Copy link
Owner

bwp91 commented Dec 27, 2023

This is really cool, thank you

@bwp91
Copy link
Owner

bwp91 commented Dec 27, 2023

@vadimpronin I was hoping you could check something further for me. (I do not have an iFan myself)

  • Update to the ewelink plugin beta which includes your fan changes
  • Update to the beta version of the Homebridge UI - I have hopefully made some changes to support the fan scale changes within the UI itself - on the Accessories page

Would you be able to confirm that it works in the Homebridge UI? ie - not displaying a % and also it sliding properly between 0 - 1 - 2 - 3?

@vadimpronin
Copy link
Contributor Author

Hey @bwp91

does the scale automatically update in the home app? or does it require removing the accessory for it to be re-added with the new scales?

The scale updates automatically after a few minutes

Would you be able to confirm that it works in the Homebridge UI? ie - not displaying a % and also it sliding properly between 0 - 1 - 2 - 3?

Being able to change the scale in the UI is cool!
Will check it tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants