Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Package.Path() return platform independent package full path #151

Merged
merged 4 commits into from
May 30, 2024

Conversation

yimoucao
Copy link
Contributor

No description provided.

.gitattributes Outdated Show resolved Hide resolved
pkg/bingo/mod.go Outdated Show resolved Hide resolved
@yimoucao
Copy link
Contributor Author

@bwplotka or @aimuz can you help review?

Copy link
Owner

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


# Force batch scripts to always use CRLF line endings so that if a repo is accessed
# in Windows via a file share from Linux, the scripts will work.
*.{cmd,[cC][mM][dD]} text eol=crlf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this magic. I trust this works and not break Linux/Mac users 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both .cmd and .bat files are Windows command scripts. On Windows their line endings have to be crlf for being processed correctly.

@bwplotka bwplotka merged commit 61fbf60 into bwplotka:main May 30, 2024
9 checks passed
@yimoucao
Copy link
Contributor Author

Thx for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants