Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Package.Path() return platform independent package full path #151

Merged
merged 4 commits into from
May 30, 2024
Merged

make Package.Path() return platform independent package full path #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f406651
add .gitattributes for clean checkout on Windows
yimoucao Apr 13, 2024
269cb0a
fix Package.Path()
yimoucao Apr 13, 2024
950830f
update README
yimoucao Apr 13, 2024
257fa9e
update typo
yimoucao Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Set default behavior to automatically normalize line endings.
* text=auto

# Force batch scripts to always use CRLF line endings so that if a repo is accessed
# in Windows via a file share from Linux, the scripts will work.
*.{cmd,[cC][mM][dD]} text eol=crlf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this magic. I trust this works and not break Linux/Mac users 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both .cmd and .bat files are Windows command scripts. On Windows their line endings have to be crlf for being processed correctly.

*.{bat,[bB][aA][tT]} text eol=crlf

# Force bash scripts to always use LF line endings so that if a repo is accessed
# in Unix via a file share from Windows, the scripts will work.
*.sh text eol=lf
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ run:

Let's show a few, real, sometimes novel examples showcasing `bingo` capabilities:

1. [`golangci-lint`](https://github.com/golangci/golangci-lint) is all-in-one lint framework. It's important to pin it on CI so CI runs are reproducible no matter what new linters are added, removed or changed in new release. Let's pin it to `v1.35.2` and use path recommended by https://golangci-lint.run/usage/install/#install-from-source doc: ` github.com/golangci/golangci-lint/cmd/golangci-lint` (funny enough they discourage `go get` exactly because of the lack of pinning features `bingo` have!)
1. [`golangci-lint`](https://github.com/golangci/golangci-lint) is all-in-one lint framework. It's important to pin it on CI so CI runs are reproducible no matter what new linters are added, removed or changed in new release. Let's pin it to `v1.35.2` and use path recommended by https://golangci-lint.run/welcome/install/#install-from-source doc: ` github.com/golangci/golangci-lint/cmd/golangci-lint` (funny enough they discourage `go get` exactly because of the lack of pinning features `bingo` have!)

```shell
bingo get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.35.2
Expand Down
6 changes: 4 additions & 2 deletions pkg/bingo/mod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"io"
"log"
"os"
"path"
"path/filepath"
"sort"
"strings"
Expand Down Expand Up @@ -70,9 +71,10 @@ func (m Package) String() string {
return m.Path() + "@" + m.Module.Version
}

// Path returns a full package path.
// Path returns a full package path. package path is platform independent, usually in
// the form of "a/b/c" with forward slashes
func (m Package) Path() string {
return filepath.Join(m.Module.Path, m.RelPath)
return path.Join(m.Module.Path, m.RelPath)
}

// ModFile is a wrapper over module file with bingo specific data.
Expand Down
Loading