Add file line numbers to errors #48
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
| @@ -48,9 +48,9 @@ func NewChain(c ...mdformatter.LinkTransformer) mdformatter.LinkTransformer { | |||
| return &chain{chain: c} | |||
| } | |||
|
|
|||
| func (l *chain) TransformDestination(ctx mdformatter.SourceContext, destination []byte) (_ []byte, err error) { | |||
| func (l *chain) TransformDestination(ctx mdformatter.SourceContext, destination []byte, lines string) (_ []byte, err error) { | |||
There was a problem hiding this comment.
lines of what? do you mean lineNumber?
I find it very confusing we need to pass lines through transformers args 🤔
Why not adding it to SourceContext?
There was a problem hiding this comment.
Didn't think of that. Will try to implement! 🙂
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
| @@ -75,6 +78,7 @@ func (t *transformer) Render(w io.Writer, source []byte, node ast.Node) error { | |||
| if token.Attr[i].Key != "src" { | |||
| continue | |||
| } | |||
| t.sourceCtx.LineNumbers = getLinkLines(source, []byte(token.Attr[i].Val), t.frontMatterLen) | |||
There was a problem hiding this comment.
I am pretty sure we can get this directly from node (...) offset 🤔
Traversing huge file might get us quite latency problems... can we try that? 🤗
There was a problem hiding this comment.
Sure! Will try to implement this! 🙂
There was a problem hiding this comment.
I can't seem to find any offset method/field which could give line numbers for a particular node. I could only find this method in text package but functionality seems to be different...
There was a problem hiding this comment.
It actually shows the offset in source 🤔 usually ;p
This PR adds line numbers to errors in the following way,
Fixes #36.