This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Allow AddProvider to still work with some custom types #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update module path add more log statements add more clear logs add more log statements in critical places remove panic causing line remove panic causing line 2 add check for custom tag handler, and logging add check for user defined provider before calling built in func put back module & imports the way they were add test and logic for checking for custom tag before defaulting to userDefinedArray func update readme and add example update example to not be random and therefore pass the test command add comment
andrew-werdna
force-pushed
the
some-custom-support
branch
from
31e8340
to
8f5d6a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 95.04% 94.90% -0.15%
==========================================
Files 10 10
Lines 989 1001 +12
==========================================
+ Hits 940 950 +10
- Misses 27 28 +1
- Partials 22 23 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, even if using
AddProvider()some custom types would not work, as there was no check formapperTag[tag]function before callinguserDefinedArray().^ it would fail with
Tag unsupported: ....even if provided with a tag!Since
AddProvider()can provide the ability to instantiate/manipulate the type, it would be great if when usingAddProvider()the user could provide a tag that would work even for some custom types.If you comment out the changes I made to
faker.goand run the testsgo test ./...you will see the failure, even thoughAddProvider()was called to add the desired tag.Fixes issue #101