Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

fix: panic on using map with value of aliased type #165

Merged
merged 3 commits into from
Aug 11, 2022
Merged

fix: panic on using map with value of aliased type #165

merged 3 commits into from
Aug 11, 2022

Conversation

daniel134256
Copy link
Contributor

@daniel134256 daniel134256 commented Aug 11, 2022 •
edited by bxcodec
Loading

The following will panic:

type Name string

func Test() {
    v := map[string]Name{}
    faker.FakeData(&v)
}

output:

panic: reflect.Value.SetMapIndex: value of type string is not assignable to type <package-name>.Name [recovered]

resolves #166

@daniel134256
fix panic on using map with value of aliased type
1630f98 
Avoid `panic: reflect.Value.SetMapIndex: value of type <BUILT-IN TYPE> is not assignable to type <ALIAS TYPE> [recovered]`
@daniel134256 daniel134256 mentioned this pull request Aug 11, 2022
Closed
bxcodec
bxcodec approved these changes Aug 11, 2022
View reviewed changes
Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxcodec bxcodec merged commit 72e5223 into bxcodec:master Aug 11, 2022
@bxcodec bxcodec changed the title fix panic on using map with value of aliased type fix: panic on using map with value of aliased type Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bxcodec bxcodec bxcodec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix panic on using map with value of aliased type
2 participants
@daniel134256 @bxcodec