Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

feat: Added price (amount and currency) | Code commented and styled #37

Merged
merged 4 commits into from Sep 24, 2018
Merged

feat: Added price (amount and currency) | Code commented and styled #37

merged 4 commits into from Sep 24, 2018

Conversation

Shivam010
Copy link
Contributor

Price added | Comments added | Code Documented and styled according to GoLang Wiki: https://github.com/golang/go/wiki/CodeReviewComments

1. price.go

  • Prices are often used with Currency Codes and hence, one can use the price tags to have mock prices

2. helpers.go

  • SliceIntToString -> IntToString

3. faker.go

  • tags string name changed
  • DAY_OF_MONTH -> DayOfMonthTag
  • TIME_PERIOD -> TimePeriodTag

4. internet.go

  • https(secure) urlFormats added
  • Url -> Url
  • Ipv4 -> Ipv4
  • Ipv6 -> Ipv6

5. lorem.go

  • Sentences -> Paragraph
  • Sentence now, directly ends with a full stop, not a space followed by full stop.
  • A randomized Paragraph is generated having lines <= 10

6. person.go

  • New Titles added
  • Male names starting with 'Y' and Female names starting with 'X' are added

@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #37 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   97.88%   98.02%   +0.14%     
==========================================
  Files           8        9       +1     
  Lines         378      406      +28     
==========================================
+ Hits          370      398      +28     
  Misses          4        4              
  Partials        4        4
Impacted Files Coverage Δ
datetime.go 100% <ø> (ø) ⬆️
payment.go 100% <ø> (ø) ⬆️
address.go 100% <ø> (ø) ⬆️
faker.go 95.45% <ø> (ø) ⬆️
phone.go 100% <100%> (ø) ⬆️
price.go 100% <100%> (ø)
person.go 100% <100%> (ø) ⬆️
internet.go 100% <100%> (ø) ⬆️
lorem.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c1be6...51485bc. Read the comment docs.

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Cool.
Thank you very much for this PR.
Looks good to me. 👍

@bxcodec bxcodec changed the title Added price (amount and currency) | Code commented and styled feat: Added price (amount and currency) | Code commented and styled Sep 24, 2018
@bxcodec bxcodec merged commit 4fc883c into bxcodec:master Sep 24, 2018
@bxcodec bxcodec mentioned this pull request Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants