Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

fix: typos ("tool_free" -> "toll_free") #52

Merged
merged 3 commits into from
Jan 31, 2019
Merged

fix: typos ("tool_free" -> "toll_free") #52

merged 3 commits into from
Jan 31, 2019

Conversation

qjcg
Copy link
Contributor

@qjcg qjcg commented Jan 30, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          10       10           
  Lines         540      540           
=======================================
  Hits          511      511           
  Misses         15       15           
  Partials       14       14
Impacted Files Coverage Δ
faker.go 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3ea06...01c0907. Read the comment docs.

@bxcodec
Copy link
Owner

bxcodec commented Jan 31, 2019

Thank you for the PR. This is a silly thing that I missed to fix :D
But changing this will be a breaking change.

@qjcg
Copy link
Contributor Author

qjcg commented Jan 31, 2019

Fair enough. My view is that misspellings in the public API can confuse and frustrate developers and convey a sense of lower code quality, and therefore merit a breaking change, but the choice is up to you of course

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then, I think it's better to merge it for now, and for the better quality ;)

@bxcodec bxcodec changed the title Fix typos ("tool_free" -> "toll_free") fix: typos ("tool_free" -> "toll_free") Jan 31, 2019
@bxcodec bxcodec merged commit 7fd2178 into bxcodec:master Jan 31, 2019
@qjcg
Copy link
Contributor Author

qjcg commented Jan 31, 2019

Awesome, thanks and keep up the great work with this library!

@bxcodec bxcodec mentioned this pull request Feb 1, 2019
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants