Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

chore: apply linter for better quality code #55

Merged
merged 7 commits into from
Feb 1, 2019
Merged

chore: apply linter for better quality code #55

merged 7 commits into from
Feb 1, 2019

Conversation

bxcodec
Copy link
Owner

@bxcodec bxcodec commented Feb 1, 2019

close #44


This PR will be merged with the new go module faker/v3
As part of #54

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #55 into gomod will decrease coverage by 1.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##            gomod      #55      +/-   ##
==========================================
- Coverage   94.62%   93.58%   -1.04%     
==========================================
  Files          10       10              
  Lines         540      546       +6     
==========================================
  Hits          511      511              
- Misses         15       18       +3     
- Partials       14       17       +3
Impacted Files Coverage Δ
address.go 100% <100%> (ø) ⬆️
phone.go 100% <100%> (ø) ⬆️
faker.go 87.5% <100%> (ø) ⬆️
uuid.go 80% <68.42%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40420f9...f97a6f7. Read the comment docs.

@bxcodec bxcodec mentioned this pull request Feb 1, 2019
6 tasks
@bxcodec bxcodec merged commit 6e28510 into gomod Feb 1, 2019
@bxcodec bxcodec deleted the lintingCode branch February 1, 2019 06:50
bxcodec added a commit that referenced this pull request Feb 1, 2019
* apply linter

* update makefile

* update travis yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant