Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

feat(faker): optionally insert nils instead of empty slices and maps #59

Merged
merged 3 commits into from
Feb 9, 2019

Conversation

olimpias
Copy link
Contributor

@olimpias olimpias commented Feb 7, 2019

SetNilIfLenIsZero called method is added for the setting nil option.

Ref: #58

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #59      +/-   ##
=========================================
+ Coverage   93.58%   93.7%   +0.11%     
=========================================
  Files          10      10              
  Lines         546     556      +10     
=========================================
+ Hits          511     521      +10     
  Misses         18      18              
  Partials       17      17
Impacted Files Coverage Δ
faker.go 88.07% <100%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24911e1...f9bf81a. Read the comment docs.

faker_test.go Outdated Show resolved Hide resolved
Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxcodec bxcodec merged commit 632fb92 into bxcodec:master Feb 9, 2019
@bxcodec bxcodec changed the title Optionally insert nils instead of empty slices and maps feat: optionally insert nils instead of empty slices and maps Feb 9, 2019
@bxcodec bxcodec changed the title feat: optionally insert nils instead of empty slices and maps feat(faker): optionally insert nils instead of empty slices and maps Feb 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants