feat(faker): length Support

[olimpias]

String len, number boundaries and array and map size have become configurable. In reference task, it was asked as a tag but I think, adding two new unnecessary field will be pointless for length setting instead making configuration will be more convenient. So It has become configurable with this PR...

fix #49

[codecov]

Codecov Report

Merging #60 into master will decrease coverage by 0.35%.
The diff coverage is 85.88%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage    93.7%   93.35%   -0.36%     
==========================================
  Files          10       10              
  Lines         556      677     +121     
==========================================
+ Hits          521      632     +111     
- Misses         18       24       +6     
- Partials       17       21       +4

Impacted Files	Coverage Δ
faker.go	89.38% <85.88%> (+1.3%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbcd79...7d4bcf0. Read the comment docs.

[bxcodec]

Thanks for the PR. Really appreciate it. This PR already looks good to me.
But, just a suggestion if you have more spare time. It will be more complete if we can also support it from the struct's tag.

Maybe something like this:

type Some struct {
ArrayOfSomething []string `faker:",maxlen=20"`
StringOfSomething string `faker:",maxlen=25"`
FirstName string `faker:"first_name, maxlen=15"`
}

*maxlen aslo can be replaced with len`

If just in case you have spare time anyway. If you too busy, then it's okay to merge this for now

[olimpias]

Sure I think, I can complete it today or tomorrow.

…

On Mon, Feb 11, 2019 at 10:32 AM Iman Tumorang ***@***.***> wrote: Thanks for the PR. Really apreciate it. This PR already looks good to me. But, just a suggestion if you have a more spare time. It will be more completed if we can also support it from the struct's tag. Maybe something like this: type Some struct { ArrayOfSomething []string `faker:",maxlen=20"` StringOfSomething string `faker:",maxlen=25"` FirstName string `faker:"first_name, maxlen=15"` } *maxlen could be replaced with only len If just in case you have a spare time anyway. If you too busy, then it's okay to merge this for now — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH_VKh6z1z0G62DGuiSB1Lw8vwMpWsTqks5vMTiPgaJpZM4azHLo> .

[olimpias]

Merging with other tags will take time. I think for now, this will be enough :).

[bxcodec]

Thank you for the PR.
If you don't mind, maybe you can add how to use it in the Readme.md.
You can add an example to existing readme.

[bxcodec]

Many thanks @olimpias

It seem looks good to merge 👍

[olimpias]

Your welcome :)

…

On Wed, Feb 20, 2019 at 10:31 AM Iman Tumorang ***@***.***> wrote: Merged #60 <#60> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH_VKjFGZVMgQ3B22mdprgalxlBSSISBks5vPRX5gaJpZM4azHLo> .