This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
fix: 0 not valid for random size #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logically invalid to as for a random number between 0 and 0 but more importantly, it panics on the Intn call with `panic: invalid argument to Intn`
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 10 10
Lines 966 966
=======================================
Hits 917 917
Misses 27 27
Partials 22 22
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code accepts 0 as a valid number for
SetRandomMapAndSliceSizethen panics on the Intn call withpanic: invalid argument to Intn