Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force android version code to numeric value #43

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

byCedric
Copy link
Owner

This fixes issues with lodash template transforming the result to string. Also, tests are updated for this usecase (although not explicitly defined).

Linked issue

Fixes #42

This fixes issues with lodash template transforming the result to string. Also, tests are updated for this usecase (although not explicitly defined).
@codeclimate
Copy link

codeclimate bot commented Sep 17, 2018

Code Climate has analyzed commit 76c34a5 and detected 0 issues on this pull request.

View more on Code Climate.

@byCedric byCedric merged commit 0f7389d into develop Sep 17, 2018
@byCedric byCedric deleted the fix/android-code branch September 17, 2018 19:34
byCedric pushed a commit that referenced this pull request Sep 17, 2018
## [2.1.1](2.1.0...2.1.1) (2018-09-17)

### Bug fixes

* force android version code to numeric value ([#43](#43)) ([0f7389d](0f7389d))

### Code refactors

* upgrade to latest peakfijn conventions ([4b0fee3](4b0fee3))

### Documentation changes

* add discussion and simple change templates ([8831ae6](8831ae6))

### Other chores

* integrate tslint and fix all found issues ([#38](#38)) ([edb9129](edb9129))
* simplify the issue and pull request templates ([#37](#37)) ([0f460df](0f460df))

### Pipeline changes

* add missing changelog package for releases ([#44](#44)) ([c169a87](c169a87))
@byCedric
Copy link
Owner Author

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android.versionCode - should be integer
1 participant