Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bybit's v5 APIs (5.0.0) #100

Merged
merged 35 commits into from
Apr 3, 2023
Merged

Upgrade to Bybit's v5 APIs (5.0.0) #100

merged 35 commits into from
Apr 3, 2023

Conversation

dextertd
Copy link
Collaborator

Reviews the contribution of #93 and brings them into master. Supersedes #85 (v3 can be seen as a stepping stone towards v5).

@dextertd
Copy link
Collaborator Author

WIP, merge next week. Mostly just websocket review plus updating documentation to come.

@dextertd
Copy link
Collaborator Author

@ervuks As you made a huge contribution towards bringing v5 to pybit, very happy to hear your comments or suggested changes on any commits I've made here.

@dextertd
Copy link
Collaborator Author

Just realised that this is the 100th issue... Very fitting!

@dextertd dextertd mentioned this pull request Mar 24, 2023
This was linked to issues Mar 24, 2023
@ervuks
Copy link

ervuks commented Mar 24, 2023

Looks great.
The only thing I would suggest is to move from legacy setuptools

@dextertd dextertd linked an issue Apr 3, 2023 that may be closed by this pull request
@dextertd dextertd merged commit 1b7162b into master Apr 3, 2023
This was referenced Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants