Issue 180 filter escape sequences #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a simplified WSPassthroughStream stream to handle any non-trivial escape sequence (whitespace like newlines and tabs are passed through). Then, the stream will call to the event handlers of a simplified LinearScreen. This screen will not emulate a 2D screen but just a linear list of data chunks received from the stream and it will emulate only the most basic escape sequences and ignore the rest. The combination of WSPassthroughStream and LinearScreen in processing the data read from the interpreter *before* being processed by pexpect makes possible the filtering without breaking the pexpect regex/prompt matching, nor breaking pre-existent examples that depend on whitespace nor adds any significant overhead to the runtime. This filtering can be optionally disabled with `-filter-esc-seqs`. For terminals other than `dumb`, no filtering is applied. See #180
eldipa
force-pushed
the
Issue-180-Filter-Escape-Sequences
branch
from
15f5d3d
to
42712c2
Compare
eldipa
force-pushed
the
Issue-180-Filter-Escape-Sequences
branch
from
42712c2
to
11ad081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180 , related with #263