Move getSourceString to String Utils #52
Conversation
string_utils.test.js
Outdated
| var STRING_JOIN_CHAR = StringUtils.STRING_JOIN_CHAR; | ||
| var getSourceString = StringUtils.getSourceString; | ||
|
|
||
| function runTest(name, expectation, func) { |
There was a problem hiding this comment.
This will dropped once #48 is merged and the repo has access to yarn+ava.
string_utils.test.js
Outdated
| * getSourceString | ||
| */ | ||
|
|
||
| var simpleString = 'simple test string'; |
There was a problem hiding this comment.
as you care more about the data type than the data itself, it might be good to use generators for this if/when #42 goes in
There was a problem hiding this comment.
I ended up leaving this as-is for now, but happy to go with the string gen instead, I just couldn't get it on the (quick) first go around.
string_utils.js
Outdated
|
|
||
| const STRING_JOIN_CHAR = "\x00"; | ||
|
|
||
| function getSourceString(obj) { |
There was a problem hiding this comment.
can we get a docblock on this function?
|
@thedavidmeister Updated with docblock. |
|
could we move tests to a subfolder? This flat nonstructure was already too big even before their arrival. |
|
@tonyofbyteball lol, i specifically made the test files flat to mimic the existing structure. Would you be able to document how you want this repo to be structured to make it easier for us to follow? |
This commit is a non-functional change. It moves the getSourceString function into its own string_utils module. Additionally, a new string_utils test is added to check the functionality. Lastly, it moves the test files into a new sub-directory named test. **Tested: Locally** - Ran all tests in the /test directory and verified they pass.
|
@tonyofbyteball @thedavidmeister I put both existing tests into a new |
|
Rebased onto #46 to use |
moving tests to a subdir is already an improvement. I don't see how the rest could be organized significantly better, creating subdirs for a 1 or 2 of files wouldn't make much sense. |
This commit is a non-functional change.
It moves the getSourceString function into its own string_utils module.
Additionally, a new string_utils test is added to check the functionality.
Lastly, it moves the test files into a new sub-directory named
/test.Tested: Locally
/testdirectory and verified they all pass.Example output
and all tests: