Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find macro asm in this scope #142

Closed
nazar-pc opened this issue Dec 16, 2021 · 7 comments · Fixed by #143
Closed

cannot find macro asm in this scope #142

nazar-pc opened this issue Dec 16, 2021 · 7 comments · Fixed by #143

Comments

@nazar-pc
Copy link

Getting these CI errors in latest nightly:

error: cannot find macro `asm` in this scope
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/rsix-0.23.9/src/imp/linux_raw/arch/inline/x86_64.rs:57:5
   |
57 |     asm!(
   |     ^^^
   |
   = note: consider importing one of these items:
           std::arch::asm
           core::arch::asm

Example CI run: https://github.com/subspace/subspace/runs/4541885325?check_suite_focus=true

@sunfishcode
Copy link
Member

Thanks for the report! This is fixed on main in #143. I'll publish a new rustix release soon, and then a Wasmtime PR to update to it. After that, it'll be in the following Wasmtime release.

@nazar-pc
Copy link
Author

Thank you for quick reaction!

@nazar-pc
Copy link
Author

nazar-pc commented Dec 18, 2021

Does this qualify for a patch release in wasmtime?

@sunfishcode
Copy link
Member

I don't think so, since it isn't a security problem, and it only affects the very latest Rust nightlies. A workaround is to temporarily pin to a Rust nightly version from a few days ago; I'd be happy to help you set this up if that would help. Also, as an update to the above, I've now made the PR to update Wasmtime, and it has now landed, so it'll be in the next regular Wasmtime release.

@nazar-pc
Copy link
Author

I have already pinned Rust nightly of course, but as many projects use latest nightly in CI, this issue is quite annoying and next wasmtime release will only be in a month, so I was hoping patch release can be issued sooner.

@sunfishcode
Copy link
Member

I recognize it's inconvenient. I volunteer to do the work to set up the workaround for any project which encounters this; just let me know in a message here.

@eminence
Copy link

For anyone following along at home, you need nightly-2021-12-15 or older

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants