refactor(swc/plugin): replace wasm runtime #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
commented
Jan 5, 2022
| nightly-2021-12-15 |
There was a problem hiding this comment.
due to bytecodealliance/rustix#142 ; once wasmtime bumps up its dependencies we can revert this.
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We started plugin implememtation with wasmer as runtime, but looks like it doesn't support all of the platforms swc currently targets.
PR attempts to replace runtime to
wasmtimeto see if it can be used for those platforms. This PR attempts to verify target support only, so replacement to wasmtime actually doesn't contain correct code to utilize plugins. It should followup after we confirm target support.BREAKING CHANGE:
Related issue (if exists):
wasmerio/wasmer#2324