Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for target x86_64h-apple-darwin #93

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add support for target x86_64h-apple-darwin #93

merged 1 commit into from
Jul 31, 2023

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jul 25, 2023 •
edited

@NobodyXu
Add support for target x86_64h-apple-darwin
e4e3db9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Copy link
Contributor Author

@sunfishcode Hello, can you review this PR please?
We recently added support for x86_64h-apple-darwin in cargo-binstall but since target-lexicon isn't able to parse this target it causes an error in our application

cargo-bins/cargo-binstall#1228

@NobodyXu NobodyXu mentioned this pull request Jul 31, 2023
Merged
@NobodyXu
Copy link
Contributor Author

@bjorn3 @sunfishcode Friendly pinging as this PR has been stale for at least one week.

@sunfishcode sunfishcode merged commit 6ac8f1b into bytecodealliance:main Jul 31, 2023
12 checks passed
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode
Copy link
Member

This is now released in target-lexicon 0.12.11.

@NobodyXu NobodyXu deleted the feature/x86_64h-apple-darwin branch August 1, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @sunfishcode