feature: Add fallback x86_64h-apple-darwin and fallback for it
#1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `detect_targets` would fallback to `x86_64h-apple-darwin` on `aarch64-apple-darwin`. It also provides fallback to `x86_64h-apple-darwin` to `x86_64-apple-darwin` and universal targets. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
|
What the heck is x86_64h |
passcod
approved these changes
Jul 23, 2023
You can check the official doc: https://doc.rust-lang.org/nightly/rustc/platform-support/x86_64h-apple-darwin.html |
|
I also wonder if we should switch to building x86_64h-apple-darwin in CI, also that will require nightly since there's no pre-built stdlib. |
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
detect_targetswould fallback tox86_64h-apple-darwinonaarch64-apple-darwin.It also provides fallback to
x86_64h-apple-darwintox86_64-apple-darwinand universal targets.