add packed type for type equal #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/iwasm/common/gc/gc_common.c
Outdated
| @@ -354,6 +354,11 @@ wasm_ref_type_equal(const wasm_ref_type_t *ref_type1, | |||
| type1 = ref_type1_norm.value_type; | |||
| type2 = ref_type2_norm.value_type; | |||
|
|
|||
| if ((type1 == VALUE_TYPE_I8 && type2 == VALUE_TYPE_I8) | |||
There was a problem hiding this comment.
This will not work, if value type is set to VALUE_TYPE_I8 or I16, seems in L348 the wasm_ref_type_normalize will fail and this function returned directly?
I think we should modify the implementation of wasm_ref_type_normalize to process VALUE_TYPE_I8 and VALUE_TYPE_I16?
There was a problem hiding this comment.
thanks for advice, seems in wasm_ref_type_normalize, on condition doesn't contain VALUE_TYPE_I16/I8, I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.