sgx-ra: disable the building of samples #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMenetrey
force-pushed
the
ra_turn_off_samples
branch
from
178252e
to
5c264ca
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developers,
This PR is a follow-up to my upgrade for the remote attestation with Ubuntu 20.04 and librats (#2441).
When integrating librats as a dependency using
add_subdirectory(), theBUILD_SAMPLESoption from the librats's CMakeLists isn't correctly overridden from the parent CMakeLists on the first run ofcmake. It requires two runs of the command to reflect the changes. The root cause is the way regular and cache variables are handled in CMake.I propose to set
BUILD_SAMPLESas a cache variable in the parent CMakeLists before invokingadd_subdirectory(). This ensures that the setting is applied on the first run.Cheers!