Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CI config and suppress STORE_U8 in TSAN #2802

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Zzzabiyaka
Copy link
Contributor

@Zzzabiyaka Zzzabiyaka commented Nov 20, 2023

This typo prevented sanitizers to work in the CI.

Because corresponding issues were found locally, we didn't miss anything initially

@Zzzabiyaka Zzzabiyaka force-pushed the makslit/fix_typo_yml branch 2 times, most recently from 1065e23 to 4d8c71d Compare November 21, 2023 14:35
@Zzzabiyaka Zzzabiyaka marked this pull request as ready for review November 21, 2023 14:52
@Zzzabiyaka Zzzabiyaka force-pushed the makslit/fix_typo_yml branch 8 times, most recently from 5345dda to 37bcc82 Compare December 8, 2023 14:42
@Zzzabiyaka Zzzabiyaka changed the title Fix typo Fix typo in CI config and suppress STORE_U8 in TSAN Dec 8, 2023
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/iwasm/common/wasm_runtime_common.h Outdated Show resolved Hide resolved
core/iwasm/interpreter/wasm_interp_fast.c Outdated Show resolved Hide resolved
core/iwasm/interpreter/wasm_interp_fast.c Show resolved Hide resolved
@wenyongh wenyongh merged commit 63696ba into bytecodealliance:main Dec 11, 2023
706 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants