Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine JIT function call process #2925

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Refine JIT function call process #2925

merged 3 commits into from
Jan 2, 2024

Conversation

wenyongh
Copy link
Contributor

@wenyongh wenyongh commented Dec 25, 2023 •
edited
Loading

  • Don't allocate the implicit/unused frame when calling the LLVM JIT function.
  • Don't set exec_env's thread handle and stack boundary in the recursive
    calling from host, since they have been set in the first time calling.
  • Fix frame not freed in llvm_jit_call_func_bytecode

yamt
yamt approved these changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
it would have been nicer if these two changes are separate PRs though.

@wenyongh
Copy link
Contributor Author

lgtm. it would have been nicer if these two changes are separate PRs though.

OK, I will separate this to two PRs.

@wenyongh wenyongh changed the title Refine JIT/AOT func calling process Refine JIT function call process Dec 29, 2023
@wenyongh
Copy link
Contributor Author

wenyongh commented Jan 2, 2024

lgtm. it would have been nicer if these two changes are separate PRs though.

OK, I will separate this to two PRs.

Done with PR #2940 created.

@wenyongh wenyongh merged commit 3637f2d into bytecodealliance:main Jan 2, 2024
393 checks passed
@wenyongh wenyongh deleted the dev/refine_wasm_func_call branch January 11, 2024 06:36
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh
Refine LLVM JIT function call process (bytecodealliance#2925)
4c501d5 
- Don't allocate the implicit/unused frame when calling the LLVM JIT function
- Don't set exec_env's thread handle and stack boundary in the recursive
  calling from host, since they have been set in the first time calling
- Fix frame not freed in llvm_jit_call_func_bytecode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyongh @yamt