SIMD: Add i64x2.all_true, i64x2.eq, i64x2.ne #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
changed the title
yurydelendik
force-pushed
the
bug1688380
branch
from
72d9dc4
to
fb83f65
Compare
|
atm selecting |
alexcrichton
approved these changes
Jan 27, 2021
Probably. I think |
|
i64x2.all_true also appears to be a mess: WebAssembly/simd#415 (comment), a consequence of insisting on "logical" blocks of instructions while not setting aside large enough open spaces, combined with a bug in V8 that disallows opcodes > 255. |
|
Well in any case y'all are much more up-to-date on simd than I am anyway, so I'm happy to merge whenever y'all are comfortable about the opcodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WebAssembly/simd#381, WebAssembly/simd#411, WebAssembly/simd#415. These have been accepted into the spec.
TODO:
fori64x2.eqandi64x2.ne