Rename assert_uncaught_exception to assert_exception #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert_uncaught_exception assertion used for exception handling was renamed to assert_exception in the final version of WebAssembly/exception-handling#160 but was out-of-date in the wast crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert_uncaught_exceptionassertion used for exception handling was renamed toassert_exceptionin the final version ofWebAssembly/exception-handling#160
but was out-of-date in the wast crate. This PR does the renaming.
(example of the current assertion syntax used in tests here: https://github.com/WebAssembly/exception-handling/blob/master/test/core/try_catch.wast#L157)
Note: the upstream "testsuite" repo isn't updated for exceptions yet, but I tested it by updating it locally. There are some differences in error messages vs. expected messages (will try to fix these sometime), but otherwise it looks pretty good after this change.