Add experimental memory.discard instruction #882
Conversation
bvisness
force-pushed
the
memory-discard
branch
from
efce5be
to
f81c17e
Compare
crates/wasmparser/src/lib.rs
Outdated
| @@ -325,6 +325,7 @@ macro_rules! for_each_operator { | |||
| @bulk_memory DataDrop { data_index: u32 } => visit_data_drop | |||
| @bulk_memory MemoryCopy { dst_mem: u32, src_mem: u32 } => visit_memory_copy | |||
| @bulk_memory MemoryFill { mem: u32 } => visit_memory_fill | |||
| @bulk_memory MemoryDiscard { mem: u32 } => visit_memory_discard | |||
There was a problem hiding this comment.
The @bulk_memory here is used as a proposal to gate access to this instruction, so this'll want to be something other than bulk_memory since otherwise memory.discard will be enabled by default.
In lieu of an official proposal, could this perhaps be something like @experimental or @memory_control? That'll require adding a field to WasmFeatures which is ok and would be necessary for this anyway.
There was a problem hiding this comment.
I'll add @memory_control I think!
There was a problem hiding this comment.
Added a @memory_control feature. I hope I set true/false correctly in the various places where it was required.
bvisness
force-pushed
the
memory-discard
branch
from
f81c17e
to
bbb4a41
Compare
|
All looks good to me, thanks again! I think CI is showing there's at least one more place to update |
bvisness
force-pushed
the
memory-discard
branch
from
bbb4a41
to
dc5b116
Compare
|
Just patching up those last couple places. Didn't realize I had to run |
bvisness
force-pushed
the
memory-discard
branch
from
dc5b116
to
3d2be3c
Compare
|
I stepped over myself a bit during publication but these crates are now all published on crates.io |
Adding support for a
memory.discardinstruction proposed in the memory control proposal, which I am prototyping within SpiderMonkey.@eqrion