Update to Wasmtime 20.0.2 to pass CI #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Merged
|
The correct c-api's are now used, but looks like there might have been some other changes required. maybe #316 |
jsturtevant
force-pushed
the
dont-use-dev-on-prs
branch
from
c2021ee
to
5303b84
Compare
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
dont-use-dev-on-prs
branch
from
5303b84
to
a816a0a
Compare
jsturtevant
changed the title
|
moved this to a branch via #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously always pulling the dev c api for wasmtime, causing failures on simple PR's like #313.
This temporally disables the dev version of the wasmtime c-api in order to get start making incremental updates as a part of fixing #315