Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assembly signing #320

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

YuliiaKovalova
Copy link

In order to resolve the problem
image

Assembly signing was added.
More info is here: https://learn.microsoft.com/en-us/dotnet/standard/assembly/strong-named#why-strong-name-your-assemblies

@YuliiaKovalova
Copy link
Author

pull the changes from #317 to have a green build

@jsturtevant
Copy link
Contributor

What's the scenario you are using and seeing this error?

Strong naming has no benefits on .NET Core/5+. C# compiler produces CS8002 warning for strong-named assemblies referencing non-strong named assemblies. It is fine to suppress this warning for libraries that target .NET Core/5+ only.

@rainersigwald
Copy link

@jsturtevant We're interested in using this library, but because our assemblies are strong-named signed for historical and .NET Framework reasons, we are disallowed from referencing it by the a-strong-named-assembly-may-not-reference-a-non-strong-named-assembly rule. Since the strong name is mostly harmless, the usual solution to this problem is to strong-name the assembly with a new key that is checked into the repo, so any build can access the private key.

@jsturtevant
Copy link
Contributor

Thanks! It does seem Microsoft recommends checking the signed key https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming#create-strong-named-net-libraries

This guidance is specific to publicly distributed .NET libraries, such as .NET libraries published on NuGet.org. Strong naming is not required by most .NET applications and should not be done by default.
✔️ CONSIDER strong naming your library's assemblies.
✔️ CONSIDER adding the strong naming key to your source control system.
A publicly available key lets developers modify and recompile your library source code with the same key.

After we sort out the current build issues, I think we can move forward with this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants