Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic macOS arm64 support #102

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Add basic macOS arm64 support #102

merged 1 commit into from
Oct 1, 2021

Conversation

danielledeleo
Copy link
Contributor

@danielledeleo danielledeleo commented Sep 30, 2021

This commit adds basic support for building on M1 Macs. For now, libwasmtime.a for macos_aarch64 must be built manually, but that part seems to be working fine.

This workflow works on my M1 MacBook running Monterey:

cd wasmtime
cargo build -p wasmtime-c-api --release

cd ../wasmtime-go
./ci/local.sh ../wasmtime

All the tests pass except for TestTrapFrames and TestTrapModuleName:

=== RUN   TestTrapFrames
    trap_test.go:34: expected 3 frames, got 1
--- FAIL: TestTrapFrames (0.00s)
=== RUN   TestTrapModuleName
    trap_test.go:90: expected 1 frame, got 0
--- FAIL: TestTrapModuleName (0.00s)

This commit adds basic support for building on M1 Macs. For now, `libwasmtime.a` for macos_aarch64 must be built manually, but that part seems to be working fine.

This workflow works on my M1 MacBook running Monterey:

```
cd wasmtime
cargo build -p wasmtime-c-api --release

cd ../wasmtime-go
./ci/local.sh ../wasmtime
```
@danielledeleo
Copy link
Contributor Author

danielledeleo commented Sep 30, 2021

It seems that cargo x86_64-apple-darwin can successfully cross compile to aarch64-apple-darwin, so maybe this could be added to the wasmtime Action?

@alexcrichton
Copy link
Member

Seems like a good start at least, thanks! I think there's more to do for correctness, yeah, but seems fine to go ahead and land this.

@alexcrichton alexcrichton merged commit ec2575c into bytecodealliance:main Oct 1, 2021
This was referenced Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants