-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub release uploads fail intermittently, breaking the install script #978
Comments
This is an attempt to mitigate #978. I'm not really sure if it'll work, but seems like it's worth trying!
Another attempt to mitigate bytecodealliance#978
Another attempt to mitigate bytecodealliance#978
Ok the plot is unfortunately thickening. After #982 uploading an asset is now done entirely in a loop. The publish logs though sure enough failed again. The retry did indeed work. The first error we got was No idea what's happening here, so time to get more coarse. #989 is an attempt to just retry the entire upload process. |
Another attempt to mitigate #978
Ok looks like that did the trick, the build at https://github.com/bytecodealliance/wasmtime/runs/470965512?check_suite_focus=true failed, then retried automatically, and succeeded on the retry. We now currently have a full suite of builds. I need to do one more fix for our tagged releases since they'll be retried as well, then I think we should be good to close this. |
This will delete a same-name of a previous release for all tags, not just the dev tag. That way if we need to retry a tagged release we'll delete it and recreate it as usual. Closes bytecodealliance#978
This will delete a same-name of a previous release for all tags, not just the dev tag. That way if we need to retry a tagged release we'll delete it and recreate it as usual. Closes #978
Our GitHub actions push workflow uploads binaries to a GitHub release—
dev
formaster
, or the last published tag for tagged releases. This upload fails intermittently, which in turn breaks our install script.We should see if there's something to be done about these failures on our end, or do something to mitigate them. One option might be to retry the upload at least a couple of times, if it's just flaky.
cc @alexcrichton
The text was updated successfully, but these errors were encountered: