Retry uploading release assets if they fail #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to mitigate bytecodealliance#978. I'm not really sure if it'll work, but seems like it's worth trying!
fitzgen
approved these changes
Feb 25, 2020
| console.log("ERROR: ", e.message); | ||
| console.log(e.stack); | ||
| console.log("RETRYING after 10s"); | ||
| await sleep(10000) |
There was a problem hiding this comment.
I guess randomized exponential backoff doesn't really matter in this case, but little lights go off in my head telling me to do that everytime there is a retry loop :-P
There was a problem hiding this comment.
Heh I agree, I'm hoping a pretty long sleep here is "roughly good enough"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to mitigate #978. I'm not really sure if it'll work,
but seems like it's worth trying!