Implement RFC 11: Redesigning Wasmtime's APIs #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is a really nice design improvement!
docs: in new-api, trap handlers are installed at Engine creation
This was referenced May 27, 2021
This was referenced May 28, 2021
bnjbvr
reviewed
Jun 1, 2021
Co-authored-by: Benjamin Bouvier <public@benj.me>
That's enabled through `wasmtime_async`
This is relegated to wasmtime-wasi
|
The RFC has been merged and this has been reviewed (thanks all!) so I'm going to merge. |
olivierlemasle
added a commit
to olivierlemasle/wasmtime
that referenced
this pull request
Jun 3, 2021
In commit 33c791e (PR bytecodealliance#2944), I added LICENSE files to all published crates. However, since then PR bytecodealliance#2897 has been merged and remove 3 crates, resulting in license files in empty directories.
This was referenced Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of RFC 11 which is a redesign of Wasmtime's APIs.
I've gotten this impelmentation to the point now where it should be passing all in-tree tests. I think the performance is suitable for performance testing as well to ensure that it doesn't regress anything. I'd like to ideally get some review on this so by the time the RFC merges it's ready to go, and I'm also curious for design feedback which may influence the RFC itself as well.
I don't recommend paying attention to the commits themselves. They're all a mess and 95% of the changes are in the first commit. I plan on squashing everything and making a better commit message before merging.
Currently the only remaining TODO item is documentation. I have not yet update the API documentation of the
wasmtimecrate or the C API, and a lot of love needs to be poured into there. I would consider this a blocker before merging, I'm just working on the actual implementation itself first (Python/Go bindings are up next). I would also like to put more work into documenting some internal design decisions in inline comments, currently I don't think there's a sufficient amount. I plan on doing this with the general documentation pass I'll be doing later this week.