Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport simd fixes to 0.38.0 #4334

merged 2 commits into from Jun 27, 2022


Copy link

@alexcrichton alexcrichton commented Jun 27, 2022

This backports #4318 and #4317 to the 0.38.0 branch for a pending and upcoming 0.38.1 release.


This commit fixes a mistake in the `Swizzle` opcode implementation in
the x64 backend of Cranelift. Previously an input register was casted to
a writable register and then modified, which I believe instructions are
not supposed to do. This was discovered as part of my investigation
into bytecodealliance#4315.

This commit fixes a bug in the previous codegen for the `select`
instruction when the operations of the `select` were of the `v128` type.
Previously teh `XmmCmove` instruction only stored an `OperandSize` of 32
or 64 for a 64 or 32-bit move, but this was also used for these 128-bit
types which meant that when used the wrong move instruction was
generated. The fix applied here is to store the whole `Type` being moved
so the 128-bit variant can be selected as well.
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Jun 27, 2022
@alexcrichton alexcrichton merged commit b3ad5f9 into bytecodealliance:release-0.38.0 Jun 27, 2022
23 checks passed
@alexcrichton alexcrichton deleted the backports branch Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants