Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove heaps from core Cranelift, push them into cranelift-wasm #5386

Merged
merged 42 commits into from
Dec 15, 2022
Merged

Remove heaps from core Cranelift, push them into cranelift-wasm #5386

merged 42 commits into from
Dec 15, 2022

Commits on Dec 14, 2022

  1. cranelift-wasm: translate Wasm loads into lower-level CLIF operations 

    Rather than using `heap_{load,store,addr}`.
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    5266ea9 View commit details
    Browse the repository at this point in the history

  2. cranelift: Remove the heap_{addr,load,store} instructions 

    These are now legalized in the `cranelift-wasm` frontend.
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4061db1 View commit details
    Browse the repository at this point in the history

  3. cranelift: Remove the ir::Heap entity from CLIF

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    900fe99 View commit details
    Browse the repository at this point in the history

  4. Port basic memory operation tests to .wat filetests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6c6cebb View commit details
    Browse the repository at this point in the history

  5. Remove test for verifying CLIF heaps

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    eb872f7 View commit details
    Browse the repository at this point in the history

  6. Remove heap_addr from replace_branching_instructions_and_cfg_predec… 

    …essors.clif test
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2ed1d32 View commit details
    Browse the repository at this point in the history

  7. Remove heap_addr from readonly.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b8f0cdb View commit details
    Browse the repository at this point in the history

  8. Remove heap_addr from table_addr.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    62e7773 View commit details
    Browse the repository at this point in the history

  9. Remove heap_addr from the simd-fvpromote_low.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0c917b0 View commit details
    Browse the repository at this point in the history

  10. Remove heap_addr from simd-fvdemote.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9b5d0e9 View commit details
    Browse the repository at this point in the history

  11. Remove heap_addr from the load-op-store.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    feab8f4 View commit details
    Browse the repository at this point in the history

  12. Remove the CLIF heap runtest

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f6ba041 View commit details
    Browse the repository at this point in the history

  13. Remove heap_addr from the global_value.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    5de2471 View commit details
    Browse the repository at this point in the history

  14. Remove heap_addr from fpromote.clif runtests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2e8408e View commit details
    Browse the repository at this point in the history

  15. Remove heap_addr from fdemote.clif runtests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    05f4b32 View commit details
    Browse the repository at this point in the history

  16. Remove heap_addr from memory.clif parser test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    540c53e View commit details
    Browse the repository at this point in the history

  17. Remove heap_addr from reject_load_readonly.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b011628 View commit details
    Browse the repository at this point in the history

  18. Remove heap_addr from reject_load_notrap.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ee4fae1 View commit details
    Browse the repository at this point in the history

  19. Remove heap_addr from load_readonly_notrap.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    66c2e7d View commit details
    Browse the repository at this point in the history

  20. Remove static-heap-without-guard-pages.clif test 

    Will be subsumed when we port `make-heap-load-store-tests.sh` to generating
`.wat` tests.
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    5dcaeb6 View commit details
    Browse the repository at this point in the history

  21. Remove static-heap-with-guard-pages.clif test 

    Will be subsumed when we port `make-heap-load-store-tests.sh` over to `.wat`
tests.
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f417937 View commit details
    Browse the repository at this point in the history

  22. Remove more heap tests 

    These will be subsumed by porting `make-heap-load-store-tests.sh` over to `.wat`
tests.
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    70a54ef View commit details
    Browse the repository at this point in the history

  23. Remove heap_addr from simple-alias.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3ba4240 View commit details
    Browse the repository at this point in the history

  24. Remove heap_addr from partial-redundancy.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    05c69e5 View commit details
    Browse the repository at this point in the history

  25. Remove heap_addr from multiple-blocks.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    131f377 View commit details
    Browse the repository at this point in the history

  26. Remove heap_addr from fence.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0645532 View commit details
    Browse the repository at this point in the history

  27. Remove heap_addr from extends.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    e725627 View commit details
    Browse the repository at this point in the history

  28. Remove runtests that rely on heaps 

    Heaps are not a thing in CLIF or the interpreter anymore
    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    18925d7 View commit details
    Browse the repository at this point in the history

  29. Add generated load/store .wat tests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    84ad8bd View commit details
    Browse the repository at this point in the history

  30. Enable memory-related wasm features in .wat tests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    463fd93 View commit details
    Browse the repository at this point in the history

  31. Remove CLIF heap from fcmp-mem-bug.clif test

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    63140e9 View commit details
    Browse the repository at this point in the history

  32. Add a mode for compiling .wat all the way to assembly in filetests

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    95b968f View commit details
    Browse the repository at this point in the history

  33. Also generate WAT to assembly tests in make-load-store-tests.sh

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    422643d View commit details
    Browse the repository at this point in the history

  34. cargo fmt

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    aca6520 View commit details
    Browse the repository at this point in the history

  35. Reinstate f{de,pro}mote.clif tests without the heap bits

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0bf088a View commit details
    Browse the repository at this point in the history

  36. Remove undefined doc link

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8dd762f View commit details
    Browse the repository at this point in the history

  37. Remove outdated SVG and dot file from docs

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    36ef819 View commit details
    Browse the repository at this point in the history

  38. Add docs about None returns for base address computation helpers

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b93ffc2 View commit details
    Browse the repository at this point in the history

  39. Factor out env.heap_access_spectre_mitigation() to a local

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d969082 View commit details
    Browse the repository at this point in the history

  40. Expand docs for FuncEnvironment::heaps trait method

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    5a53cd0 View commit details
    Browse the repository at this point in the history

  41. Restore f{de,pro}mote+load clif runtests with stack memory

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    1cd66b5 View commit details
    Browse the repository at this point in the history

  42. Fix test expectation that referenced old heap setting

    @fitzgen
    fitzgen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    e2b6cf5 View commit details
    Browse the repository at this point in the history