[wasmtime-wasi] fix logic error in monotonic-clock/subscribe
#6993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating the number of nanoseconds to wait, we should subtract the current time from the deadline, not vice-versa. This was causing guests to sleep indefinitely due to integer underflow. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Sep 11, 2023
Note that this is annotated `should_panic` when testing preview1 scenarios, since those won't have preview2 imports. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
|
I've added a test. |
pchickey
approved these changes
Sep 11, 2023
alexcrichton
pushed a commit
that referenced
this pull request
Sep 12, 2023
* [wasmtime-wasi] fix logic error in `monotonic-clock/subscribe` When calculating the number of nanoseconds to wait, we should subtract the current time from the deadline, not vice-versa. This was causing guests to sleep indefinitely due to integer underflow. Signed-off-by: Joel Dice <joel.dice@fermyon.com> * add `sleep` test to `wasi-tests` Note that this is annotated `should_panic` when testing preview1 scenarios, since those won't have preview2 imports. Signed-off-by: Joel Dice <joel.dice@fermyon.com> --------- Signed-off-by: Joel Dice <joel.dice@fermyon.com>
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 13, 2023
…odealliance#6993) * [wasmtime-wasi] fix logic error in `monotonic-clock/subscribe` When calculating the number of nanoseconds to wait, we should subtract the current time from the deadline, not vice-versa. This was causing guests to sleep indefinitely due to integer underflow. Signed-off-by: Joel Dice <joel.dice@fermyon.com> * add `sleep` test to `wasi-tests` Note that this is annotated `should_panic` when testing preview1 scenarios, since those won't have preview2 imports. Signed-off-by: Joel Dice <joel.dice@fermyon.com> --------- Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the number of nanoseconds to wait, we should subtract the current time from the deadline, not vice-versa. This was causing guests to sleep indefinitely due to integer underflow.