Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasmtime-wasi] fix logic error in monotonic-clock/subscribe #6993

Merged
merged 2 commits into from Sep 11, 2023
Merged

[wasmtime-wasi] fix logic error in monotonic-clock/subscribe #6993

merged 2 commits into from Sep 11, 2023

Commits on Sep 11, 2023

  1. [wasmtime-wasi] fix logic error in monotonic-clock/subscribe 

    When calculating the number of nanoseconds to wait, we should subtract the
current time from the deadline, not vice-versa.  This was causing guests to
sleep indefinitely due to integer underflow.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
    @dicej
    dicej committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    acbea30 View commit details
    Browse the repository at this point in the history

  2. add sleep test to wasi-tests 

    Note that this is annotated `should_panic` when testing preview1 scenarios,
since those won't have preview2 imports.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
    @dicej
    dicej committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    f2d69dc View commit details
    Browse the repository at this point in the history