Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #7859 to release-18.0.0 #7878

Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 6, 2024

…ass (bytecodealliance#7859)

* Cranelift: Use a fixpoint loop to compute the best value for each eclass

Fixes bytecodealliance#7857

* Remove fixpoint loop early-continue optimization

* Add document describing optimization rule invariants

* Make select optimizations use subsume

* Remove invalid debug assert

* Remove now-unused methods

* Add commutative adds to cost tests
@fitzgen fitzgen requested a review from a team as a code owner February 6, 2024 19:23
@fitzgen fitzgen requested review from elliottt and removed request for a team February 6, 2024 19:23
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!

@fitzgen fitzgen merged commit a94657a into bytecodealliance:release-18.0.0 Feb 6, 2024
42 checks passed
@fitzgen fitzgen deleted the release-18.0.0-egraphs-fix branch February 6, 2024 20:10
@fitzgen
Copy link
Member Author

fitzgen commented Feb 6, 2024

NB: wasmtime 18 hasn't released yet, so no need to start the patch release process now that this has merged. This will go out with the main 18 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants