-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mach
dependency with mach2
#8049
Conversation
@@ -1735,6 +1735,15 @@ dependencies = [ | |||
"libc", | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The region crate used by cranelift-jit still depends on mach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, its not a dependency of wasmtime, and we can snip that dependency in a follow up PR if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the region PR for moving to mach2 has been open for several months: darfink/region-rs#27 And worse the last release has been from over 2 years ago and once the current version gets released, it will lock the libc crate to version 0.2.107 from 2 years ago (for OpenBSD 6.9 support, which has been EOL since May 2022. libc presumably dropped support for it because it is EOL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@cfallin would you be up for fixing the aarch64 macOS build here? The last commit was too aggressive, and seems to have removed things that are still needed in |
I can take a look, sure. |
Pushed a fix; with this it |
Ah, but with that there is a panic at that |
OK, so the issue (one issue anyway) is that |
Testing locally I'm seeing something that looks like it's running into this comment, namely the bindings for |
Notably the |
I've pushed a commit which passes tests locally by copying over the copy of the struct that we have today and additionally queues up all tests to run in CI. |
Rebase of #6164 with added audit.
Fixes #6000
Fixes #6164
Fixes #8044